BitBoxSwiss / bitbox-wallet-app

The BitBoxApp for desktop and mobile.
https://bitbox.swiss/app
Apache License 2.0
254 stars 82 forks source link

frontend/backend: show outputs as individual row for receive transactions #2843

Open NicolaLS opened 2 months ago

NicolaLS commented 2 months ago

Closes: #1728

Display each output of a receive transaction as one transaction in the app. The outputs data is only added to the endpoint response if the transaction is of type receive. Non-utxo model transactions e.g. ETH will just contain a single item in the outputs field which is weird but fine imo.

In the current implementation the index used for the note key (txid:idx) is set/defined by the order of the Adresses in the TransactionData struct returned by txInfo (here)

Probably it would be better to add index to TransactionOutput and actually set it to the transactions output index and then use that in the frontend. Let me know if you think the current implementation is fine or if I should change that.

NicolaLS commented 2 months ago

This can be tested by checking out #2844

./scripts/regtest/run_regtest.sh
make servewallet-regtest
make webdev
cd ./scrips/regtest/
export DOCKER_REGTEST=1
source examples.sh
mine_blocks 101
example_bitbox_receive_many