search

BitBoxSwiss / bitbox02-api-js

BitBox02 JavaScript library
Other
11 stars 9 forks source link

Remove additional offset of 27 #51

Closed benma closed 3 years ago

benma commented 3 years ago

Since https://github.com/digitalbitbox/bitbox02-api-go/commit/971fa13fa6d4f3cf78df85ddfe6fcad8a4b541c2, the offset of 27 is added already in the Go library.

The update was pulled in in c4379142f5c596327eab20e9bc9f3b53e6c70b46.

Adding the offset again is incorrect.

benma commented 3 years ago

I tested signing a tx and a message using this PR in a local MEW build and it worked.