search

BitBoxSwiss / bitbox02-api-js

BitBox02 JavaScript library
Other
11 stars 9 forks source link

package: add types definition #61

Open BrianCraig opened 2 years ago

BrianCraig commented 2 years ago

Add types defintion for the package

benma commented 2 years ago

I'll review the types tomorrow or latest Thursday, but in the meantime:

Does this constitute a minor or major version bump? Can this break downstream users of this package when upgrading?

thisconnect commented 2 years ago

Does this constitute a minor or major version bump? Can this break downstream users of this package when upgrading?

In worst case I assume it could break a CI, better make it a major bump IMO.

BrianCraig commented 2 years ago

I'll review the types tomorrow or latest Thursday, but in the meantime:

Does this constitute a minor or major version bump? Can this break downstream users of this package when upgrading?

If we cover all usages, it shouldn't break CI, only where there it is a bad usage. But something that i don't know is what types does GopherJS understand as a byte[], because we are using Uint8Array, but it may be accepting more than that (does accept number[]?)

benma commented 2 years ago

Discussed offline - this PR is paused for a few weeks pending other changes to the package that will impact the types.