search

BitBoxSwiss / bitbox02-firmware

Firmware code of the BitBox02 hardware wallet
https://bitbox.swiss/bitbox02
Apache License 2.0
217 stars 81 forks source link

ethereum: warn if fee is higher than 10% #1012

Closed benma closed 1 year ago

benma commented 1 year ago

Only for standard transactions, where the fee and amount are of the same unit. In ERC20-txs, the fees are in ETH while the token is of a different unit.

benma commented 1 year ago

tACK with one question: the num-bigint update is required by the feature or could be split in a separate PR?

Could actually be split.

benma commented 1 year ago

Accidentally merged a rebased version of this, which means the commits are in mater, but the PR was not closed. Closing manually.