BitBoxSwiss / bitbox02-firmware

Firmware code of the BitBox02 hardware wallet
https://bitbox.swiss/bitbox02
Apache License 2.0
217 stars 81 forks source link

unit-test/keystore: simplify by removing some mocks #1028

Closed benma closed 1 year ago

benma commented 1 year ago

These unit tests are hard to maintain as there is a lot of mocking with willreturn and expect*. We don't need to mock salt_hash_data and securechip_kdf results, we use existing mock implementations of these that perform the real function (in case of securechip_kdf, the mocked one from mock_securechip.c).