search

BitBoxSwiss / bitbox02-firmware

Firmware code of the BitBox02 hardware wallet
https://bitbox.swiss/bitbox02
Apache License 2.0
217 stars 81 forks source link

eth: fix protobuf generated file to remove Goerli #1048

Closed benma closed 1 year ago

benma commented 1 year ago

In 8b454550f4961b2d7380885fbd45526d8c5d42bd, Goerli was added, but accidentally in the generated file, not in the source file. The generated file is only refreshed if the source files change, which is why the CI did not catch it.

Since we changed to using chainID instead of ETHCoin in 519a58b17e4692f5d2e6a5793f4c8fc09a312e2c, we remove it again from the protobuf file.

Similarly, the generated files were not regenerated when updating Prost to 0.11. in 412e3400d627ab0b994df5a92f34c95478535ae5, which adds more changes to the generated file, like formatting and the as_str_name/from_str_name methods.

benma commented 1 year ago

fyi @Beerosagos - noticed this after the protobuf generated file was regenerated, removing GoerliEth again.