search

BitBoxSwiss / bitbox02-firmware

Firmware code of the BitBox02 hardware wallet
https://bitbox.swiss/bitbox02
Apache License 2.0
217 stars 81 forks source link

keystore: encrypt seed in RAM #1056

Closed benma closed 1 year ago

benma commented 1 year ago

Related: https://github.com/digitalbitbox/bitbox02-firmware/pull/1057

benma commented 1 year ago

tACK, very nice!

Adding some comments could help code readability, e.g. specifying the purpose of retained seeds where declared and adding function comments for _stretch_retained_seed_encryption_key and keystore_copy_seed. It took me a bit to understand the concept of retained seed by inspecting the code..

Thanks! Added some comments.