search

BitBoxSwiss / bitbox02-firmware

Firmware code of the BitBox02 hardware wallet
https://bitbox.swiss/bitbox02
Apache License 2.0
217 stars 81 forks source link

api/bitcoin: allow exporting xpub at any keypath with confirmation #1087

Closed benma closed 1 year ago

benma commented 1 year ago

So far we prohibited unusual keypaths (e.g. non bip-44/49/84 keypaths).

When using descriptors/miniscript, there are no specific keypaths to whitelist - the user confirms the keypath at policy registration time. We need to allow exporting the xpub at any keypath so the a descriptor wallet app can construct a policy using BitBox02 xpubs.

Beerosagos commented 1 year ago

@benma One nit I just noticed: Since the warning message is longer than the available display size, it doesn't look like a warning at first sight, as it starts with unusual keypath... Would be nice to have it start with warning:, (maybe also in capital letters?) to allow a distracted user immediately understand that he need to pay attention to what is going on.

benma commented 1 year ago

@benma One nit I just noticed: Since the warning message is longer than the available display size, it doesn't look like a warning at first sight, as it starts with unusual keypath... Would be nice to have it start with warning:, (maybe also in capital letters?) to allow a distracted user immediately understand that he need to pay attention to what is going on.

good point! fixed, also for a similar message in ethereum.