Closed cstenglein closed 9 months ago
@benma applied your suggestions and squashed the commits into one.
Can't build the firmware with the build script somehow due to the following error:
2.742 error: failed to compile `bindgen-cli v0.65.1`, intermediate artifacts can be found at `/tmp/cargo-installTljSy0`
2.742
2.742 Caused by:
2.742 package `clap_derive v4.4.2` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.69.0
2.742 Try re-running cargo install with `--locked`
Tried to add --locked
to the cargo install
commands in the Dockerfile
but didn't work somehow.
@cstenglein as a workaround you can run docker pull shiftcrypto/firmware_v2:latest
to get the last image, enter it using make dockerdev
and compile in there: make -j firmware
. That is generally preferred during development, as building the whole docker image every time would be way too time consuming.
I'll look into this issue.
Thank you for the fast reply!
docker pull shiftcrypto/firmware_v2:latest to get the last image, enter it using make dockerdev and compile in there: make -j firmware. That is generally preferred during development, as building the whole docker image every time would be way too time consuming.
I got another error while doing that:
CMake Error at /usr/share/cmake-3.22/Modules/ExternalProject.cmake:2882 (message):
No download info given for 'libwally-core' and its source directory:
Full error files are below.
Looks like you didn't check out the submodules. git clone --recursive
. Maybe git submodule update --init --recursive
will do it, but it's always hard to remember submodule comands :P
Looks like you didn't check out the submodules.
git clone --recursive
. Maybegit submodule update --init --recursive
will do it, but it's always hard to remember submodule comands :P
Thank you, now it works!
Wasted so much time building the firmware all the time, so much faster now <3
Thank you very much! Couldn't have done it without you :+1:
Forgot one more thing: could you add a line to CHANGELOG.md under [Unreleased]?
- Disable screensaver when displaying a receive address, confirming a transaction, and other interactive actions
Done :+1:
resolves #856
First of all, thank you for the dev device!
Tested the receive and send screens with this change, the screen saver doesn't appear there any more. Since the receive screen uses the
confirm
Component, other confirms have the screen saver disabled as well.Since I'm far away from C/C++, I'm not sure if the position of the enable / disable are correct there.