search

BitBoxSwiss / bitbox02-firmware

Firmware code of the BitBox02 hardware wallet
https://bitbox.swiss/bitbox02
Apache License 2.0
217 stars 81 forks source link

Eip1559 #1138

Closed Tomasvrba closed 7 months ago

Tomasvrba commented 8 months ago

should be all fixed, check fixup commits I can squash them all once ACKed

benma commented 7 months ago

@Tomasvrba I fixed the bug with chain_id=0 (and added a eip1559_unhappy test for it), bumped the fw version to 9.16.0, and rebased (fixed conflicts). I also squashed all commits.

Tomasvrba commented 7 months ago

@Tomasvrba I fixed the bug with chain_id=0 (and added a eip1559_unhappy test for it), bumped the fw version to 9.16.0, and rebased (fixed conflicts). I also squashed all commits.

Nice, thanks! Anything else that needs to be done here?

benma commented 7 months ago

@Tomasvrba I fixed the bug with chain_id=0 (and added a eip1559_unhappy test for it), bumped the fw version to 9.16.0, and rebased (fixed conflicts). I also squashed all commits.

Nice, thanks! Anything else that needs to be done here?

Don't think so, I just wanted to test it in the BitBoxApp to make sure it works before merging it.