search

BitBoxSwiss / bitbox02-firmware

Firmware code of the BitBox02 hardware wallet
https://bitbox.swiss/bitbox02
Apache License 2.0
256 stars 91 forks source link

releases: add userofreddit44 pubkey assertion for v9.12.0 #978

Closed userofreddit44 closed 1 year ago

userofreddit44 commented 1 year ago

Reproduced firmware (multi-edition) v9.12.0 successfully.

userofreddit44 commented 1 year ago

Sorry. I may or may not of squash-ed the commits correctly.

benma commented 1 year ago

Sorry. I may or may not of squash-ed the commits correctly.

Yeah, now there are six commits instead of one :smile: Please try again to make only one commit.

benma commented 1 year ago

@userofreddit44 let me know if you need help with this. If git squashing etc. is too much trouble, you could make a new branch and add your changes again from a clean slate and open a new PR.

git checkout -b assertion origin/master
<apply changes>
git commit ... (use same key to sign the commit as you use to sign the assertion.txt)
userofreddit44 commented 1 year ago

@benma Learning how to squash is still on my agenda, it's just a matter of when, I will let you know if I incur anything too problematic on my attempt/s so thanks, I will indeed close this PR as it looks like spaghetti.