search

BitBoxSwiss / html_backup

7 stars 14 forks source link

Add issue and commit templates instructing people to always tag someo… #8

Closed TheCharlatan closed 6 years ago

TheCharlatan commented 6 years ago

…ne to review the pr/take the issue @benma

stephaniestroka commented 6 years ago

I'm a bit confused by this issue. Do you mean that you want to tag reviewers in the git commit message?

benma commented 6 years ago

No, mark them as reviewers, or tag them in the PR message/comment.

stephaniestroka commented 6 years ago

Then I'm unsure what to do with this issue. @TheCharlatan can you explain?

TheCharlatan commented 6 years ago

This just adds a standard text that will appear in this text box, when you opene either an issue, or a pull request to "@" the maintainers so (i) they definitely get a notification and (ii) there is someone responsible for the patch.

stephaniestroka commented 6 years ago

Oh I see. For some reason I thought that it's an issue, not a PR. Will merge (and trust you that it's fine ;-))

stephaniestroka commented 6 years ago

A short meta-complaint: You could have assigned a reviewer to this PR :stuck_out_tongue:

TheCharlatan commented 6 years ago

I did, @benma is the first line of the PR text body. Non-maintainers of a github repository cannot asign people to pull requests, they have to @ them so they get a notification.

stephaniestroka commented 6 years ago

Ohh, I see. Sorry, didn't think about that!