Missing error message when putting in wrong password after scan QR

BitCannaGlobal / WeedMobile

5 stars 1 forks source link

Missing error message when putting in wrong password after scan QR #30

Closed TJ-BitCanna closed 8 months ago

TJ-BitCanna commented 11 months ago

No error is shown here when you click "Send" with the wrong password. 2023-10-13 14 04 34

atmoner commented 9 months ago

Bad password error message added!

Fixed here:

TJ-BitCanna commented 9 months ago

Works!

Can the error message also be auto-removed as soon as the correct password is used and the transaction is send on chain?

TJ-BitCanna commented 9 months ago

Scanning and the error message work perfectly on iOS as well.

Only the error message needs to be removed when the correct password is used. Small detail to make it 100% ok.

atmoner commented 9 months ago

Scanning and the error message work perfectly on iOS as well.

Only the error message needs to be removed when the correct password is used. Small detail to make it 100% ok.

I haven't tested it (I have to wait for the next compilation) but normally, I added a condition to remove the error message with each new scan

Fixed here: https://github.com/BitCannaGlobal/WeedMobile/commit/ffb5b7ac6b4d0219f06e8f906fb27bc8aa9c469f

TJ-BitCanna commented 9 months ago

Small update: It is not that the error message stays after scanning a QR, but more the following:

user scans QR
gets screen to confirm the transaction
puts in wrong password
error message is shown
user puts in correct password
the button changes to a rotating circle, BUT the error message of the wrong password is also still shown

Would be quite nice if in the last step the error message is also removed automtically.

TJ-BitCanna commented 8 months ago

Works!