Remove the X / 6 checks on textboxxes

TJ-BitCanna commented 11 months ago

2023-10-13 14 22 07

atmoner commented 10 months ago

@TJ-BitCanna However, it will be necessary to define a capacity limit to avoid overload problems, see issue #9 (check my answer)

TJ-BitCanna commented 10 months ago

Limit password field to 20 characters.

Limit memo field to 100 characters.

Limit addressbook names to 20 characters.

Limit address field to the max length of a bcna1xxxxxxx address.

This should cover most fields, right?

atmoner commented 9 months ago

@TJ-BitCanna

Limit password field to 20 characters

Limit memo field to 100 characters

Limit addressbook names to 20 characters

Obviously, if you find other fields that we need to limit, don't hesitate to tell me!

Fixed: here and here

TJ-BitCanna commented 9 months ago

Password: ok

Memo: field is not limited to 100 characters in the "Send" process (check this transaction: https://testnet.ping.pub/bitcanna/tx/644649170C9BAB9299A8F481FF72B6FB66A6B18CC1320CEA6EBAD46713074955)

Memo: field is not limited to 100 characters in the "Create QR" screen

Name in addressbook: ok

Address in "Send" screen: ok

Address in addressbook: ok

TJ-BitCanna commented 9 months ago

Also in screen 3 of "Create wallet" the "X / 6" is still available.

And no limit on the length of the "Wallet name" field

atmoner commented 9 months ago

Also in screen 3 of "Create wallet" the "X / 6" is still available.

And no limit on the length of the "Wallet name" field

Exact! I add limitation on memo send tx to 100 And remove x6 on create wallet page (step3)

Fixed here: https://github.com/BitCannaGlobal/WeedMobile/commit/ff10b0bf4c54147dbe5034b12d0f357cc5714d25

TJ-BitCanna commented 9 months ago

Couple of things noticed:

no limit on the length of the "Wallet name" field in screen 3 of adding a wallet
no limit on length of the "Wallet name" field when importing a wallet
"0/6" still available on length of the "Wallet name" when importing a wallet
when sending a tx the field "memo" nicely turns red with an error message the amount of characters in the field is too long. However, you can still click "Send" and continue to the next page. Buttons need to check for error messages and block proceeding until the error message is resolved.

atmoner commented 8 months ago

Couple of things noticed:

no limit on the length of the "Wallet name" field in screen 3 of adding a wallet

no limit on length of the "Wallet name" field when importing a wallet

"0/6" still available on length of the "Wallet name" when importing a wallet

when sending a tx the field "memo" nicely turns red with an error message the amount of characters in the field is too long. However, you can still click "Send" and continue to the next page. Buttons need to check for error messages and block proceeding until the error message is resolved.

I fixed each item on your list point by point! Fixed here: https://github.com/BitCannaGlobal/WeedMobile/commit/ef90a038d105d48db6858f3ea0d2063314262324

TJ-BitCanna commented 8 months ago

Remaining action:

wallet name in step 3 of importing a wallet nicely turns red, but you can still save the address. The red warning is not blocking it.
Wallet name for importing is stating 10 characters (should be 20)
Wallet name for importing is not red marked when to long
Check if a wallet name for importing is blocking saving the address

atmoner commented 8 months ago

Effectively! there was a problem with the return of data on the actions, I found the problem and everything returned to normal!!

Fixed here: https://github.com/BitCannaGlobal/WeedMobile/commit/dfbe135faac61b76b736f6fcfa615692d93aaa06

RaulBernal commented 8 months ago

Tested and ok

BitCannaGlobal / WeedMobile