search

BitCannaGlobal / WeedMobile

5 stars 1 forks source link

Bad password at "View Mnemonic" doesn't do anything #39

Closed TJ-BitCanna closed 9 months ago

TJ-BitCanna commented 10 months ago

Using a wrong password when trying to view the mnemonic does not give an error message: 2023-11-14 14 56 02

atmoner commented 9 months ago

@TJ-BitCanna this page is a bit experimental! let me explain: I did a live password verification test, you can see that this allows you to remove the "validate" button and that the mnenomic is displayed automatically when the password is good.

the problem is that with this method, the password status is always "bad" so if I add an error message, the message will always be visible!

Obviously, I can return to a simple form with a button like in the rest of the app, it's your choice!

TJ-BitCanna commented 9 months ago

Yeah, a simple form would do ^^

More predictable behaviour for the user I think.

atmoner commented 9 months ago

@TJ-BitCanna image

Fixed here: https://github.com/BitCannaGlobal/WeedMobile/commit/1e92eee2701439ea9243c0d4a2c779c0b31fb2b3

TJ-BitCanna commented 9 months ago

Perfect on Android!

TJ-BitCanna commented 9 months ago

Works on iOS!