search

BitCannaGlobal / WeedMobile

5 stars 1 forks source link

Removing navigation bar (home, accounts, settings) #43

Closed TJ-BitCanna closed 9 months ago

TJ-BitCanna commented 9 months ago

Remove the bottom bar containing the buttons to the "Dashboard" "Accounts" and "Settings" from the QR generator page. See the difference between the screens: 2023-11-27 10 33 02 2023-11-27 10 33 12

atmoner commented 9 months ago

See the difference between the screens

@TJ-BitCanna  The difference between the two is simple: 1/ Create qrcode is a page (with the bottom menu) 2/ Send token is a modal (which covers the bottom menu)

So if you want me to remove the bar below, I have to convert the create qrcode page to a modal but the create qrcode page will no longer appear in the left menu!

It's your choice ​

TJ-BitCanna commented 9 months ago

Aaah, it is anyway desired to keep it in the left menu.

There is no parameter to supress the navigation bar in the bottom on a page when the keyboard is opened? Or, check for example Whatsapp. The navigation bar stays in the bottom in there, would that be a possibility? The keyboard is placed above the navigation bar instead of below.

atmoner commented 9 months ago

I suggest something! I added page detection throughout the app and if the page is equal to "Create-qrcode", the footer is disabled! Please note that I can add any page in this condition so if you encounter the same problem on another page, I can add the deactivation of the footer quickly

image

image

Fixed here: https://github.com/BitCannaGlobal/WeedMobile/commit/ed8eac7d1b0e60e7d39adc68371470b470232f04

TJ-BitCanna commented 9 months ago

Looks good and ok to me :)