Decide what to do with files in inc/Temporary

BitFunnel / NativeJIT

A C++ expression -> x64 JIT

http://bitfunnel.org/

MIT License

1.14k stars 85 forks source link

Decide what to do with files in inc/Temporary #20

Open MikeHopcroft opened 8 years ago

MikeHopcroft commented 8 years ago

These are allocator interfaces that will also be used in BitFunnel. Options seem to be

Maintain separate versions, one in the NativeJIT namespace, and one in the BitFunnel namespace.
Make both NativeJIT and BitFunnel take a dependency on a 3rd repo that provides these interfaces.
Make BitFunnel depend on NativeJIT for these interfaces.

danluu commented 8 years ago

(1) seems sub-optimal given that we're planning on bundling NativeJIT into BitFunnel via either git subtree or git submodule. If there's no way to get BitFunnel without NativeJIT, (1) seems like it's asking for trouble without really having any upside.

I don't have a preference between (2) and (3). (2) seems "better" in some abstract sense, but my vote is for whichever is easier since I don't think it's going to matter much.