Add Sapling support for transaction parsing and encoding

BitGo / bitgo-utxo-lib

UTXO coins functions implemented in pure JavaScript

86 stars 146 forks source link

Closed argjv closed 6 years ago

argjv commented 6 years ago

Implement Sapling support for Zcash in testnet.

Melvillian commented 6 years ago

You still have locations where you're not using the is*Compatible functions. Do a Ctrl + F in the file for all occurrences of the following 3 vars:

Transaction.ZCASH_OVERWINTER_VERSION
Transaction.ZCASH_SAPLING_VERSION
Transaction.ZCASH_JOINSPLITS_SUPPORT_VERSION

paddyquinn commented 6 years ago

Looks good. Can you squash 979189f and 3dbf126 into b403064 and 52ef3c6 into bfe2a25 and then I will approve it.

@argjv