search

BitGo / bitgo-utxo-lib

UTXO coins functions implemented in pure JavaScript
86 stars 146 forks source link

Add native segwit prefix for litecoin #35

Closed murchandamus closed 5 years ago

murchandamus commented 5 years ago

It would probably be sensible to add litecoin testnet at the same time.

OttoAllmendinger commented 5 years ago

indeed

argjv commented 5 years ago

I found the reason why the tests are failing. It's a legacy "feature" of the original library. It has nothing to do with the LTC params.

Basically, the problem is the method fromBase58() can take an array of network objects, but when it does that, it just pops the last one, in this case, the litecointest one.

We should move these 2 network objects above the bitcoin one... I know... It's super bad. So please, also add a TODO in the faulty method to remove array support and create a GitHub issue.