search

BitGo / bitgo-utxo-lib

UTXO coins functions implemented in pure JavaScript
83 stars 142 forks source link

Update Zcash mainnet network params due to Blossom upgrade #49

Closed argjv closed 4 years ago

argjv commented 4 years ago

BLOCK-214 New branch id id 0x2BB40E60: https://github.com/zcash/zips/blob/master/zip-0206.rst

murchandamus commented 4 years ago

BLOCK-214 New branch id id 0x2BB40E60: https://github.com/zcash/zips/blob/master/zip-0206.rst

Could you please add both those references to the commit message?

murchandamus commented 4 years ago

Given that you said the network id will only be valid after the hard fork has gone live, we should probably come up with some sort of strategy when to merge this. Also, I would recommend to bump the major version of this package instead of the patch in that case.

argjv commented 4 years ago

Platform will need a new PR (in progress), SDK and other dependencies will need to be rebuilt. This is a mandatory change, not optional. Updating the major version will send the wrong message, updating the minor one will propagate the change more easily.

argjv commented 4 years ago

Squashed. We don't do major bumps even when we add new coins, so this does not merit one. The next major bump will be when we more to Typescript which will change the API.

murchandamus commented 4 years ago

Adding a new coin is adding a feature. Here, we're essentially ending support for the coin Zcash (Sapling) as well as adding support for a new coin Zcash (Blossom) which imho is a breaking change that predicates a major bump.

murchandamus commented 4 years ago

The next major bump will be when we more to Typescript which will change the API.

Hasn't Bitcoinjs already ported most of the codebase to Typescript?