Closed OttoAllmendinger closed 4 years ago
The upstream PR that introduced BufferWriter has had some significant changes: https://github.com/bitcoinjs/bitcoinjs-lib/pull/1533
In particular, we now also have BufferReader. Also we can and should use both classes in many more places.
Subclass BufferReader with ZcashBufferReader and implement readInt64() there.
ZcashBufferReader
readInt64()
Replace fixtures for readInt64() with test/forks/zcash/bufferutils.js.
test/forks/zcash/bufferutils.js
Issue: BG-16466
The upstream PR that introduced BufferWriter has had some significant changes: https://github.com/bitcoinjs/bitcoinjs-lib/pull/1533
In particular, we now also have BufferReader. Also we can and should use both classes in many more places.
Subclass BufferReader with
ZcashBufferReader
and implementreadInt64()
there.Replace fixtures for
readInt64()
withtest/forks/zcash/bufferutils.js
.Issue: BG-16466