BitGo / bitgo-utxo-lib

UTXO coins functions implemented in pure JavaScript
83 stars 142 forks source link

refactor(block): use BufferReader/BufferWriter #74

Closed OttoAllmendinger closed 4 years ago

OttoAllmendinger commented 4 years ago

The upstream PR that introduced BufferWriter has had some significant changes: https://github.com/bitcoinjs/bitcoinjs-lib/pull/1533

In particular, we now also have BufferReader. Also we can and should use both classes in many more places.

Subclass BufferReader with ZcashBufferReader and implement readInt64() there.

Replace fixtures for readInt64() with test/forks/zcash/bufferutils.js.

Issue: BG-16466