Zcash: add setConsensusBranchId() to TansactionBuilder

BitGo / bitgo-utxo-lib

UTXO coins functions implemented in pure JavaScript

83 stars 142 forks source link

Zcash: add setConsensusBranchId() to TansactionBuilder #89

Closed matthewzipkin-bitgo closed 2 years ago

matthewzipkin-bitgo commented 3 years ago

adds setConsensusBranchId as property to Transaction
sets that value by default based on transaction version
updates the default values for "Canopy" hard fork
use setConsensusBranchId() to maintain test success with old transaction version (from "Heartwood" fork)
- also see: https://github.com/BitGo/bitgo-utxo-lib/pull/78

TODO:

[x] Prepare consumers of this library to setConsensusBranchId() with Heartwood value until the day of the hard fork
[x] Add test vectors for Canopy transactions

TICKET BG-24753

matthewzipkin-bitgo commented 3 years ago

@OttoAllmendinger @argjv this is ready for review and release -- with at least a minor version bump so consuming applications don't accidentally use the new value before the hard fork activates on mainnet. I'll work on updating those modules now.

matthewzipkin-bitgo commented 3 years ago

Moving this to https://github.com/BitGo/bitgo-utxo-lib/pull/90 to rebase on v1.7.1

OttoAllmendinger commented 3 years ago

reopening this in order to fix master branch

reset this to 7434dc4 (before 1.7.x rebase), added my signatures and pushed again

OttoAllmendinger commented 2 years ago

obsoleted by https://github.com/BitGo/BitGoJS/tree/master/modules/utxo-lib