Zcash: add setConsensusBranchId() to TansactionBuilder

BitGo / bitgo-utxo-lib

UTXO coins functions implemented in pure JavaScript

83 stars 142 forks source link

Zcash: add setConsensusBranchId() to TansactionBuilder #90

Closed matthewzipkin-bitgo closed 3 years ago

matthewzipkin-bitgo commented 3 years ago

https://github.com/BitGo/bitgo-utxo-lib/pull/89 but rebased on v1.7.1

TICKET BG-24753

matthewzipkin-bitgo commented 3 years ago

Ok thanks - still making sure it runs correctly as a dep to wallet-platform. Once I'm confident it works I'll come back and merge. Also should we call this version 1.7.2? My concern is if its required using ^ then some package that isn't ready (doesn't have consensus ID set) will pull it down anyway -- but we already have a 1.8.x and 1.9.x I think. So...?

OttoAllmendinger commented 3 years ago

the fact that this changes the default way zcash transactions are built actually suggests we bump the minor version

Alternatively we could instead release a version of this lib that supports the new consensusBranchId in a convenient way without defaulting to it. That way we can decide at the callsite somehow.

argjv commented 3 years ago

We are releasing 1.7.2 because the latest version in master breaks platform and other places. Fixing utxo-lib is not in the roadmap.