BitGo / eth-multisig-v2

Multi-Sig Wallet v2, supporting original Wallet.sol methods with additional confirmAndExecute improvements to allow for single-transaction signing by multiple owners.
Apache License 2.0
271 stars 101 forks source link

USDT and OMG's transfer function return nothing. #17

Closed bruce-plutusds closed 3 months ago

bruce-plutusds commented 5 years ago

We think all tokens are ERC20 compatible but they aren't. For example, USDT and OMG's transfer function return nothing. When Forwarder receive these tokens, it cannot be flushed. So for this token flush, we add new flush functions to the Forwarder and WalletSimple.

https://medium.com/coinmonks/missing-return-value-bug-at-least-130-tokens-affected-d67bf08521ca https://medium.com/@chris_77367/explaining-unexpected-reverts-starting-with-solidity-0-4-22-3ada6e82308c