BitGo / key-recovery-service-v2

Key Recovery Service server for all v2 coins and ERC20 tokens
Apache License 2.0
8 stars 21 forks source link

BG-10832 fixed xlm and eth signing issues #52

Closed dannydeezy closed 5 years ago

dannydeezy commented 5 years ago

Motivation

https://bitgoinc.atlassian.net/browse/BG-10832

We had some issues signing ERC-20 and XLM production recoveries.

Overview of Changes

The issue with XLM is that when you send to an unfunded address, it is a different type of payment operation, so we need to handle that.

This issue with the ERC-20 tokens were that bitgo.coin() does not accept the token name, but instead accepts the tokenContractAddress.