search

BitGo / key-recovery-service-v2

Key Recovery Service server for all v2 coins and ERC20 tokens
Apache License 2.0
8 stars 21 forks source link

BG-18745 Implement initial Drone CI for this KRSv2 project. #68

Closed james8nguyen closed 4 years ago

james8nguyen commented 4 years ago

JIRA Ticket

https://bitgoinc.atlassian.net/browse/BG-18745

Change Description

The following changes have been added: 1) Add initial Drone CI pipeline with .drone.jsonnet (with Danny G's help converting from .drone.yml to .drone.jsonnet. Didn't need it.)

2) In "checks" pipeline, add "lint test" which shows quite a few errors which need to be fixed.

3) Add pipeline with "unit tests" for node 6. There are failing tests to be fixed. https://drone.bitgo-dev.com/BitGo/key-recovery-service-v2/20/2/5

4) Add pipeline with both "unit tests" and "audit test" for node 10. This pipeline is failing for obviously reasons. To resolve the failures and vulnerabilities, both package.json and package-lock.json must be upgraded with later versions of dependencies, and below is the PR for that. https://github.com/BitGo/key-recovery-service-v2/pull/70

Tests

james8nguyen commented 4 years ago

Given the latest requirements of obsoleting support for node 6, adding support for node 10, and extracting lint test into a different PR, I'm closing this PR and consolidating into PR https://github.com/BitGo/key-recovery-service-v2/pull/70. Thank you all for your valuable feedbacks.