search

BitGo / key-recovery-service-v2

Key Recovery Service server for all v2 coins and ERC20 tokens
Apache License 2.0
8 stars 21 forks source link

BG-18658 Implement CI pipeline for our KRSv2 project. #70

Closed james8nguyen closed 4 years ago

james8nguyen commented 4 years ago

JIRA Tickets

https://bitgoinc.atlassian.net/browse/BG-18658 https://bitgoinc.atlassian.net/browse/BG-19294 https://bitgoinc.atlassian.net/browse/BG-19213 https://bitgoinc.atlassian.net/browse/BG-19209

Change Description

Added the following changes:

  1. Obsolete build/test support for Node 6 (BG-19294).

  2. Add build/test support for Node 12 (BG-19213).

  3. Add build/test support for Node 10 (BG-19209).

  4. Disable eslint temporarily and move into another PR per Tyler's request (BG-19296).

  5. Upgrade the following dependencies to fix security vulnerabilities as part of Node 10/12 support (BG-19209).

    • SDK bitgo 10.0.0
    • bitgo/statics 3.4.2
    • bitgo/account-lib 1.0.2
    • stellar-hd-wallet 0.0.10 (result of npm audit fix)
    • mocha 7.1.1 (result of npm audit fix)

Notes

1) There are still failing unit tests to be fixed in both pipelines. 2) There were still lint errors / warnings which would be fixed later in separate PR.

Given failing unit tests, current branch protection may not allow to merge. To get this into master branch, we may need to bypass it initially.

Tests: