BitMEX / api-connectors

Libraries for connecting to the BitMEX API.
https://www.bitmex.com/app/restAPI
910 stars 795 forks source link

c# client - don't use #63

Closed cemdev closed 6 years ago

cemdev commented 6 years ago

This client is awful. I'll save you some time now, because I wish someone had for me. The authentication doesn't work because they've done it in a way where the parameters can be reordered so you can sign the message properly without rewriting every. single. function. And the functions are terrible. So much code duplication it's embarrassing.

And despite the readme promising a websocket client -there isn't one.

Just don't use the autogenned swagger library at all, it's actually horrific. Code from scratch using the actual bitmex c# client. (not the autogenned c# client)

joggerjoel commented 6 years ago

I wrote mine in java connecting to wss. I’ve recorded close to half month with little dropping. If anyone want to send me eth/btc, then I can assist.

On Wed, 3 Jan 2018 at 13:43, cemdev notifications@github.com wrote:

This client is awful. I'll save you some time now, because I wish someone had for me. The authentication doesn't work because they've done it in a way where the parameters can be reordered so you can sign the message properly without rewriting every. single. function. And the functions are terrible. So much code duplication it's embarrassing.

And despite the readme promising a websocket client -there isn't one.

Just don't use the autogenned swagger library at all, it's actually horrific. Code from scratch using the actual bitmex c# client. (not the autogenned c# client)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BitMEX/api-connectors/issues/63, or mute the thread https://github.com/notifications/unsubscribe-auth/AGR30yVB2-33K222ymyfcYqJBsQZ6za0ks5tGxN0gaJpZM4RRXWz .

STRML commented 6 years ago

The code is autogenerated. Expect duplication because it's literally generated from a template. If you think the template is wrong or has bugs please contribute to https://github.com/swagger-api/swagger-codegen.