search

BitMaker-hub / NerdMiner_v2

Improved version of first ESP32 NerdMiner
Other
1.37k stars 249 forks source link

Store and restore screen settings cross reboots #323

Open KaSt opened 4 months ago

KaSt commented 4 months ago

Hello, I'm taking liberty to submit to your review and consideration the following pull request. I have a few boards running this little gem of software but some are not running all the time. Hence I thought it could have been useful to restore the latest orientation and screen "cycle" selection. Could only test it on T-Display and QT Pro.

Thanks for your great work, de verdad me gusta un monton!

BitMaker-hub commented 4 months ago

Thanks for your PR, this is something a lot of people requested. I'll try to merge the following week with the other PRs

dwightmulcahy commented 3 months ago

So I pulled and tried this on a LILYGO T-Display-S3 and it messed up the orientation of the screen (portrait vs landscape). :/

KaSt commented 3 months ago

Ouch, sorry, unfortunately don’t have one of those boards (yet), only tested it on the ones I had home. Did you try switching orientation again?

On Tue, 12 Mar 2024 at 23:49, dWiGhT @.***> wrote:

So I pulled and tried this on a LILYGO T-Display-S3 and it messed up the orientation of the screen (portrait vs landscape). :/

— Reply to this email directly, view it on GitHub https://github.com/BitMaker-hub/NerdMiner_v2/pull/323#issuecomment-1992703376, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABEJ6VFNITHEVNG5KWIKGTYX6A6NAVCNFSM6AAAAABDGOSZKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSG4YDGMZXGY . You are receiving this because you authored the thread.Message ID: @.***>

sany3001 commented 3 months ago

I am still no more able to build my project.

Compiling .pio/build/TTGO-T-Display/src/ShaTests/nerdSHA256plus.cpp.o
In file included from /home/jiri/.platformio/packages/toolchain-xtensa-esp32/xtensa-esp32-elf/sys-include/sys/reent.h:503,
                 from /home/jiri/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32/include/newlib/platform_include/sys/reent.h:17,
                 from /home/jiri/.platformio/packages/toolchain-xtensa-esp32/xtensa-esp32-elf/sys-include/stdio.h:60,
                 from src/ShaTests/nerdSHA256.cpp:2:
/home/jiri/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32/include/newlib/platform_include/assert.h:20:10: fatal error: sdkconfig.h: No such file or directory

This file really not exists in my local project. I am not aware I have deleted this. Building for T-Display.

BitMaker-hub commented 3 months ago

I think I need to merge the actual PRs and make a little bit clean on the project. I'm finishing an update on NerdAxe repo, when I finish it this week I'll start the cleaning

julio-matarranz commented 3 months ago

I think I need to merge the actual PRs and make a little bit clean on the project. I'm finishing an update on NerdAxe repo, when I finish it this week I'll start the cleaning

Thank you @BitMaker-hub I have two questions : 1) Is there a Discord or did you plan to make one ? 2) Have you considered to grant some reviewers on NerdMiner to help you ?

dwightmulcahy commented 3 months ago

Please don't merge this PR; it still needs work on the other devices as evident by it not working on the LILYGO T-Display-S3.

BitMaker-hub commented 2 months ago

@julio-matarranz 1- I didn't have a Discord for this project, but we could think about it 2- Could you reach me at telegram or any other platform to talk abou it? I think is interesting too