search

BitMaker-hub / NerdMiner_v2

Improved version of first ESP32 NerdMiner
Other
1.37k stars 249 forks source link

t-hmi model improvements and bugfixes #379

Closed cosmicpsyop closed 1 month ago

cosmicpsyop commented 2 months ago

1/ Enable battery option

2/ Improve pool data api URL discovery based on Settings.PoolAddress and/or Settings.PoolPort it is possible that this is applicable to ESP32_2432S028R || ESP32_2432S028_2USB || ESP32_2432S024 || NERDMINER_T_HMI

BitMaker-hub commented 2 months ago

I've seen your changes, should not be any problem. Just one question. Why you changed so many pins on this board since previous release? I can't test it because I don't have this board, so I'll assume you are right on your changes. Can you provide some photos or graphic results?

cosmicpsyop commented 2 months ago

There are no UI changes affected by this PR although one could contend that there should be. I realized when I was testing the different pools that support that API the title is part of the graphic and remains Public-Pool.io. It probably should be dynamically replaced with the pool name entered. I did not have time to reach out to a ESP32_2432S028 maintainer to if could get a hand with coverage.

The pins have always been confusing for me in terms of the naming convention when reading from the lilygo repo. I was trying to align to nerdminer standards while trying to sort out the sdcard functionality which is critical as I understand for the SDCard class. In the end, I could not get cards recognized with the 1-Bit configuration and filed a ticket for help https://github.com/Xinyuan-LilyGO/T-HMI/issues/27

I left a bit of a mess in that file trying different things. Same could be said for the touch screen and the third button.

cosmicpsyop commented 1 month ago

@BitMaker-hub cleaned up lilygoT_HMI.h, leaving SDMMC_1BIT and touchscreen disabled for now.