search

BitMaker-hub / NerdMiner_v2

Improved version of first ESP32 NerdMiner
Other
1.37k stars 249 forks source link

t-hmi platformio lib_deps fix dev build #413

Closed cosmicpsyop closed 1 month ago

cosmicpsyop commented 1 month ago

discovered this only after clearing my workspace cache.

julio-matarranz commented 1 month ago

Dear, Thanks I already fixed the dev branch before seeing your PR 😅

julio-matarranz commented 1 month ago

Eventually if you want to upgrade to latest stable version of mathertel/OneButton and run some tests it would be nice. Otherwise I would do it soon ☺️

cosmicpsyop commented 1 month ago

I'm happy to if you let me know the version I need to bump to.

julio-matarranz commented 1 month ago

I'm happy to if you let me know the version I need to bump to.

You can find versions on platformio's registry https://registry.platformio.org/libraries/mathertel/OneButton

cosmicpsyop commented 1 month ago

i was just thinking of doing a github action for PRs and look at you. you already started working it. kewl https://github.com/BitMaker-hub/NerdMiner_v2/pull/403

julio-matarranz commented 1 month ago

i was just thinking of doing a github action for PRs and look at you. you already started working it. kewl

https://github.com/BitMaker-hub/NerdMiner_v2/pull/403

Yes introduced automatic prerelease on dev branch but it needs more access rights to work.