search

BitPhinix / slate-yjs

Yjs binding for Slate
https://docs.slate-yjs.dev
MIT License
514 stars 73 forks source link

Throw error in non-static connect call if editor is already connected #352

Closed BitPhinix closed 2 years ago

BitPhinix commented 2 years ago

Pretty self-explanatory. While it's not recommended to call editor.connect directly, a lot of users do which might result in the YjsEditor attaching its handlers twice

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 8fd37fbaa5b26c1c96c035aaa0321b1683c0f2ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | @slate-yjs/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #352 (8fd37fb) into main (ea8673e) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   71.31%   71.31%           
=======================================
  Files          30       30           
  Lines        2301     2301           
  Branches      297      297           
=======================================
  Hits         1641     1641           
  Misses        660      660
Impacted Files Coverage Δ
packages/core/src/plugins/withYjs.ts 81.07% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea8673e...8fd37fb. Read the comment docs.