BitPhinix / slate-yjs

Yjs binding for Slate
https://docs.slate-yjs.dev
MIT License
514 stars 73 forks source link

catch errors thrown in absolutePositionToSlatePoint #355

Closed AntonNiklasson closed 1 year ago

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: d25983da1fc0e9f3eb17d3f0f09969df642fdba7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #355 (d25983d) into main (ea8673e) will decrease coverage by 0.18%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   71.31%   71.13%   -0.19%     
==========================================
  Files          30       30              
  Lines        2301     2307       +6     
  Branches      297      297              
==========================================
  Hits         1641     1641              
- Misses        660      666       +6     
Impacted Files Coverage Δ
packages/core/src/utils/position.ts 41.80% <0.00%> (-0.86%) :arrow_down:
packages/core/src/plugins/withYjs.ts 81.07% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea8673e...d25983d. Read the comment docs.

AntonNiklasson commented 2 years ago

I'll update the tests if this is a decent idea 😌