search

BitPhinix / slate-yjs

Yjs binding for Slate
https://docs.slate-yjs.dev
MIT License
514 stars 73 forks source link

Fixed useUnsetCursorPositionOnBlur not hiding cursors. #376

Open FindAPattern opened 2 years ago

FindAPattern commented 2 years ago

useUnsetCursorPositionOnBlur does not hide cursors when the remote editor blurs. This happens because useUnsetCursorPositionOnBlur only sets the cursor state field to null on blur, but does not set the client data field to null, which prevents the client from being deleted from the awareness state.

One possible fix is to delete both fields on blur.

Another possible fix (this PR) is to remove the cursor if the selection range gets deleted.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: f99181faaaa4aaa058f029c7c630727d261f33eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

FindAPattern commented 2 years ago

Didn't see the contributing instructions. I'll see what I can do about creating a test to reproduce this issue.