search

BitPhinix / slate-yjs

Yjs binding for Slate
https://docs.slate-yjs.dev
MIT License
514 stars 73 forks source link

fixes 394 - applyDelta produces incorrect operations #402

Closed juliankrispel closed 1 year ago

juliankrispel commented 1 year ago

Fixes #394 - applyDelta produces incorrect operations.

Loom: https://www.loom.com/share/a05b2ce6a4c6411d850aab47213eeb71?from_recorder=1&focus_title=1

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 47840c27a18fb0f32384093405f632a93b760650

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | -------------------------- | ----- | | @slate-yjs/core | Major | | @slate-yjs/react | Major | | @slate-yjs/example-backend | Patch | | @slate-yjs/example | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

BitPhinix commented 1 year ago

Thanks for the deep dive, really appreciate you taking the time and looking into this 🙏. This seems basically gtg, if you add a changset I’ll merge it and release a new version.

BitPhinix commented 1 year ago

@juliankrispel if you prefer I can add one as well

juliankrispel commented 1 year ago

Thanks for the review @BitPhinix - I've added a changeset!