search

BitbucketPHP / Client

Bitbucket API 2.0 client for PHP
MIT License
99 stars 26 forks source link

Pipeline Config URI should use a Hypen #66

Closed Humni closed 3 years ago

Humni commented 3 years ago

Version: 4.0.0

Requests URIs are being built with an underscore instead of a hyphen. For instance:

// Fetched using `dd(self::prepareUri($uri, $params));` at AbstractAPI.php:87 
/2.0/workspaces/{workspace}/pipelines_config/variables

These result in an exception: Bitbucket\Exception\RuntimeException: Resource not found: There is no API hosted at this URL.

The URI should actually be:

/2.0/workspaces/{workspace}/pipelines-config/variables
GrahamCampbell commented 3 years ago

Bitbucket's documentation says it is with an underscore: https://developer.atlassian.com/bitbucket/api/2/reference/resource/.

Humni commented 3 years ago

@GrahamCampbell it's worse than that, it's only for some pipelines config endpoints (they use a mix) for some ungodly reason

image

GrahamCampbell commented 3 years ago

Oh, dear!