Bitcoin-ABC / ElectrumABC

Mirror of https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/electrum/
https://bitcoinabc.org/electrum
Other
32 stars 16 forks source link

Fix transaction version for hardware wallets #275

Closed PiRK closed 1 year ago

PiRK commented 1 year ago

Switching to transaction version=2 in #267 broke support for Trezor and Ledger devices. The transaction version needs to be explicitly specified when calling the relevant signing API.

PiRK commented 1 year ago

Tested with a Ledger Nano S and a Trezor T. Tested for a multisig setup with a Ledger Nano X.

Mengerian commented 1 year ago

Tested it out with Ledger, and it works now.