Bitcoin-ABC / bitcoin-abc

Bitcoin ABC develops node software and infrastructure for the eCash project. This a mirror of the official Bitcoin-ABC repository. Please see README.md
https://reviews.bitcoinabc.org
MIT License
1.24k stars 782 forks source link

Change the default datadir to bitcoincash, not bitcoin. #141

Open afk11 opened 6 years ago

afk11 commented 6 years ago

Describe the issue

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. start bitcoin cash

Expected behaviour

Should create a directory, ~/.bitcoincash

Actual behaviour

It uses ~/.bitcoin and writes to bitcoins debug.log, and other files.

What version of bitcoin-abc are you using?

2a10748d48f9a895f349b6b8411461acff777dc5 compiled from source

Machine specs:

Polve commented 6 years ago

That's an issue for me too, I would suggest ".bitcoinabc" as an alternative name, this way I can use multiple node daemons on the same user.

NiKiZe commented 6 years ago

I would suggest using the same method as bitcoin classic started, it better follows the standard for how data should be placed, and can also "play nice" with other chains with shared history (just to keep it simpler for those that still need to use other legacy coins until fully migrated)

aotto1968 commented 6 years ago

well today my Bitcoin-ABC destroy my Bitcoin-CLASSIC database… because after automatic restart…(using the option set on configuration)… the "datadir" commandline option from the previous start was NOT set… and Bitcoin-Cash start using the "default" datadir ".bitcoin"… starting immedietly destroying the Bitcoin-Core database.

→ that is the reason you should NEVER use the same default's as your competitor…

thijstriemstra commented 6 years ago

well today my Bitcoin-ABC destroy my Bitcoin-CLASSIC database…

Lost any coins, or was wallet.dat not affected?

aotto1968 commented 6 years ago

can NOT say that "bitcoin" are lost… I use this system only as node…

justusranvier commented 6 years ago

In addition to changing the default data directory, the binary names should be changed as well so it's possible to have multiple implementations installed on the same system.