Bitcoin-ABC / bitcoin-abc

Bitcoin ABC develops node software and infrastructure for the eCash project. This a mirror of the official Bitcoin-ABC repository. Please see README.md
https://reviews.bitcoinabc.org
MIT License
1.24k stars 782 forks source link

Windows bitcoincash: Protocol Registration WRONG #148

Open RealityRipple opened 6 years ago

RealityRipple commented 6 years ago

Not sure when or where you guys set the HKEY_CLASSES_ROOT\bitcoin-abc registry value, but it should be HKEY_CLASSES_ROOT\bitcoincash instead. You should probably also change the URL:Bitcoin to URL:BitcoinCash or something for the default value of the key. As it is, the software thinks it should handle bitcoin-abc:bitcoincash:MYADDRHERE, but then completely fails to parse it once it receives it. In the same vein, the protocol handler needs one change: standardized handling of spaces. Spaces are not usually allowed in URIs, and end up getting replaced with plus signs or percent-twenties, as we all know, but the program currently treats both of those as plain text. It's probably best to follow Uniform Resource standards when using Uniform Resource Identifiers and Locations. Otherwise, it's practically impossible to include a space in a value via an HTML Form object. Also, there should be some clarification as to whether the bitcoincash: prefix should be listed once or twice. If it's part of the value, a full URI would, by standards, be bitcoincash:bitcoincash:MYADDRHERE, which the software does seem to handle, but it should either be mentioned as allowed or not preferred or something, or specifically ruled out in the specs by simply saying the protocol must be included in plain-text and QR code representations rather than implying the prefix is part of the address.

schancel commented 6 years ago

If you are a windows developer, it would be great to have a pull request for this.

jkister commented 6 years ago

you beat me by 10 days - I just had this thought about the uri. in that ticket, it was pointed out that at least the the double-prefix notation is specifically invalid.