search

Bitcoin-ABC / bitcoin-abc

Bitcoin ABC develops node software and infrastructure for the eCash project. This a mirror of the official Bitcoin-ABC repository. Please see README.md
https://reviews.bitcoinabc.org
MIT License
1.24k stars 779 forks source link

error: in txvalidationcache_tests/checkinputs_test #358

Closed mercurytoxic closed 4 years ago

mercurytoxic commented 4 years ago

This issue tracker is only for technical issues related to bitcoin-abc.

General bitcoin questions and/or support requests and are best directed to the Bitcoin StackExchange.

For reporting security issues, please contact people privately.

Describe the issue

Fails the Bitcoin test suite. checkinputs_test

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. Yes, just run the Bitcoin test suite

Expected behaviour

Should complete the test suite with no errors

Actual behaviour

/bin/sh: line 1: 4042284 Aborted                 (core dumped) test/test_bitcoin -l test_suite -t "`cat test/txvalidationcache_tests.cpp | grep "BOOST_FIXTURE_TEST_SUITE(\|BOOST_AUTO_TEST_SUITE(" | cut -d '(' -f 2 | cut -d ',' -f 1 | cut -d ')' -f 1`" > test/txvalidationcache_tests.cpp.test.log 2>&1
Running 2 test cases...
Entering test module "Bitcoin Test Suite"
test/txvalidationcache_tests.cpp(26): Entering test suite "txvalidationcache_tests"
test/txvalidationcache_tests.cpp(37): Entering test case "tx_mempool_block_doublespend"
test/txvalidationcache_tests.cpp(37): Leaving test case "tx_mempool_block_doublespend"; testing time: 125587us
test/txvalidationcache_tests.cpp(153): Entering test case "checkinputs_test"
test/txvalidationcache_tests.cpp(283): error: in "txvalidationcache_tests/checkinputs_test": check chainActive.Tip()->GetBlockHash() == block.GetHash() has failed
test/txvalidationcache_tests.cpp(284): error: in "txvalidationcache_tests/checkinputs_test": check pcoinsTip->GetBestBlock() == block.GetHash() has failed
test_bitcoin: validation.cpp:1288: bool CheckInputs(const CTransaction&, CValidationState&, const CCoinsViewCache&, bool, uint32_t, bool, bool, const PrecomputedTransactionData&, std::vector<CScriptCheck>*): Assertion `!coin.IsSpent()' failed.
unknown location(0): fatal error: in "txvalidationcache_tests/checkinputs_test": signal: SIGABRT (application abort requested)
test/txvalidationcache_tests.cpp(284): last checkpoint
test/txvalidationcache_tests.cpp(153): Leaving test case "checkinputs_test"; testing time: 845551us
test/txvalidationcache_tests.cpp(26): Leaving test suite "txvalidationcache_tests"; testing time: 971199us
Leaving test module "Bitcoin Test Suite"; testing time: 971486us

*** 3 failures are detected in the test module "Bitcoin Test Suite"
test_bitcoin: /usr/include/boost/thread/pthread/condition_variable_fwd.hpp:81: boost::condition_variable::~condition_variable(): Assertion `!posix::pthread_mutex_destroy(&internal_mutex)' failed.
make[3]: *** [Makefile:13226: test/txvalidationcache_tests.cpp.test] Error 1
make[3]: Leaving directory '/tmp/trizen-pizzaman/bitcoin-abc/src/bitcoin-abc-0.20.6/src'
make[2]: *** [Makefile:12052: check-am] Error 2
make[2]: Leaving directory '/tmp/trizen-pizzaman/bitcoin-abc/src/bitcoin-abc-0.20.6/src'
make[1]: *** [Makefile:11737: check-recursive] Error 1
make[1]: Leaving directory '/tmp/trizen-pizzaman/bitcoin-abc/src/bitcoin-abc-0.20.6/src'
make: *** [Makefile:764: check-recursive] Error 1
==> ERROR: A failure occurred in check().

What version of bitcoin-abc are you using?

0.20.6.tar.gz from https://github.com/Bitcoin-ABC/bitcoin-abc/archive/v0.20.6.tar.gz

Machine specs:

jasonbcox commented 4 years ago

Thanks for reporting. This is already fixed on latest master: https://reviews.bitcoinabc.org/D4451