search

Bitcoin-ABC / bitcoin-abc

Bitcoin ABC develops node software and infrastructure for the eCash project. This a mirror of the official Bitcoin-ABC repository. Please see README.md
https://reviews.bitcoinabc.org
MIT License
1.24k stars 779 forks source link

rpcRunLater race in walletpassphrase #375

Open kryvel opened 4 years ago

kryvel commented 4 years ago

Hi, I encountered with deadlock on concurrent walletpassphrase rpc call in bitcoin wallet. The same behavior in bitcoin-abc too. Here is a description of the issue https://github.com/bitcoin/bitcoin/issues/18482

Could you please backport the fix to bitcoin-abc ?

jasonbcox commented 4 years ago

Thanks for bringing this to our attention. We'll keep tabs on the that developing issue and it's associated fix.

kryvel commented 4 years ago

I could confirm, that test case, provided in #18482, shows that issue is present in bitcoin-abc latest version, and the suggested fix is working. After compiling with fixed rpcwallet.cpp issue is gone.

kryvel commented 4 years ago

HI, @jasonbcox Any update on this? Is it planned to include it to the next release ?

jasonbcox commented 4 years ago

Sorry for the delay. The fix is now under review: https://reviews.bitcoinabc.org/D7908 I expect the fix will make it in the next release (0.22.5) which comes out on October 27th.

jasonbcox commented 4 years ago

The change has landed on master. If you want to test it before the 0.22.5 release, can you try latest master and confirm the fix?