Is mocha dependency necessary to run bitbox?

Bitcoin-com / bitbox-sdk

BITBOX SDK for Bitcoin Cash

https://developer.bitcoin.com/bitbox

MIT License

89 stars 62 forks source link

Is mocha dependency necessary to run bitbox? #120

Closed devalbo closed 5 years ago

devalbo commented 5 years ago

I upgraded to bitbox-sdk 8.4.0 in my react/Typescript project and I think @types/mocha dependency is causing a conflict with my jest dependency. According to my package-lock.json, @types/mocha is needed by bitbox-sdk. Is this actually true? Or can you make it a dev dependency?

cgcardona commented 5 years ago

Thanks for pointing this out. I moved the types for mocha, chai and sinon to dev dependencies. The fix is in bitbox-sdk v8.4.2

🎩