[fix] document hash code review adjustments

lucasmgv commented 4 years ago

Fixes of https://github.com/Bitcoin-com/mint/pull/50#pullrequestreview-355806395

mocked api link removed
layout updates as requested
adjustments on form validation

required_fields fix_before_load fix_after_load

BytesOfMan commented 4 years ago

Looks good -- some additional changes after seeing how this looks:

[ ] Remove the asterisks requested in my last comment
[ ] Above the "How can I add an icon?" collapse, insert a collapse titled "More options..."
[ ] Under the newly inserted "More options..." collapse, include the "white paper, document hash" field and the "token website" field (remove these fields from their current location between token name and decimals
[ ] If user attempts to hash a file larger than 25MB, throw an error. I don't think white papers will be larger than 25 MB and, without a progress bar, hashing larger files will take some time.

This way, only the required options are displayed by default.

lucasmgv commented 4 years ago

Looks good -- some additional changes after seeing how this looks:

[ ] Remove the asterisks requested in my last comment

[ ] Above the "How can I add an icon?" collapse, insert a collapse titled "More options..."

[ ] Under the newly inserted "More options..." collapse, include the "white paper, document hash" field and the "token website" field (remove these fields from their current location between token name and decimals

[ ] If user attempts to hash a file larger than 25MB, throw an error. I don't think white papers will be larger than 25 MB and, without a progress bar, hashing larger files will take some time.

This way, only the required options are displayed by default.

The 25MB size limit is working and the layout adjustments below:

form more-opt-open before-ldng after-ldn

Bitcoin-com / mint

[fix] document hash code review adjustments #53