search

BitcoinAndLightningLayerSpecs / lsp

API specifications for Lightning Service Providers
MIT License
112 stars 31 forks source link

LSPS0 typo nit: JSON does not support numbers with leading 0s #106

Open ZmnSCPxj-jr opened 7 months ago

ZmnSCPxj-jr commented 7 months ago

https://nullprogram.com/blog/2019/12/28/

LSPS0 Common Schemas describes "Client rejected" as 001 https://github.com/BitcoinAndLightningLayerSpecs/lsp/blob/main/LSPS0/common-schemas.md#001-client-rejected however JSON does not support numbers with leading 0s. I suggest rewriting it as 1 instead to prevent misleading implementations into actually writing an actual 001 in the actual JSON.

SeverinAlexB commented 7 months ago

Ack. I think this reasoning is stronger than "error codes should always have at least 3 digits for it to be recognizable".