LSPS1: Fix create order response example

BitcoinAndLightningLayerSpecs / lsp

API specifications for Lightning Service Providers

MIT License

112 stars 31 forks source link

LSPS1: Fix create order response example #109

Closed tnull closed 7 months ago

tnull commented 7 months ago

The payment object should be identical to the one introduced in 3., which indicates the field should be named bolt11_invoice rather than lightning_invoice.

SeverinAlexB commented 7 months ago

Insta merge IMO. Do you agree?

tnull commented 7 months ago

Yup, I think this should be uncontroversial.

tnull commented 7 months ago

Actually, I found a few other things. Let me add them here.

SeverinAlexB commented 7 months ago

FYI: This PR fixes the same lines as #107.

tnull commented 7 months ago

FYI: This PR fixes the same lines as #107.

Yes, realized that 131bcb8365fe86041490dc6cbc0d2ff955531f59 is redundant to it after the fact. Happy to drop it if we rather go with #107, but probably easiest to go with the superset here now?

SeverinAlexB commented 7 months ago

Merge decision in todays meeting