LSPS1: Fix minor inconsistencies

BitcoinAndLightningLayerSpecs / lsp

API specifications for Lightning Service Providers

MIT License

112 stars 32 forks source link

Closed tnull closed 5 months ago

tnull commented 5 months ago

In #101, a few inconsistencies were introduced, but some were also preexisting.

In any case, here we fix a number of minor inconsistencies:

We align the invoice and address fields of the BOLT11 payment/onchain payment options when referenced in different parts of the spec.
We now ensure all monetary amounts / _sat fields are JSON strings as defined in LSPS0 Common Schemas.

(cc @ErikDeSmedt)

SeverinAlexB commented 5 months ago

Good catch 👍

kaloudis commented 5 months ago

LGTM 👍

tnull commented 5 months ago

Let me know if you want to have this Insta merged @tnull

SGTM, let's merge this ASAP