LSPS1: Fix mirror back refund_onchain_address

BitcoinAndLightningLayerSpecs / lsp

API specifications for Lightning Service Providers

MIT License

112 stars 32 forks source link

LSPS1: Fix mirror back refund_onchain_address #123

Closed SeverinAlexB closed 2 months ago

SeverinAlexB commented 3 months ago

Mirror back the refund_onchain_address given by the client. Solves #122.

SeverinAlexB commented 3 months ago

Marked address as optional to make it backwards compatible. @tnull Do you think the spec is now clear enough? Eriks comment in the issue did add some context.

tnull commented 3 months ago

Marked address as optional to make it backwards compatible. @tnull Do you think the spec is now clear enough? Eriks comment in the issue did add some context.

Mhh, so AFAICT it's a bit weird that we have a separate CANCELLED state as CANCELLED for Lightning has the same semantics as REFUNDED for onchain now? So should we drop/deprecate one of them? I.e., should we only ever have a REFUNDED state?

Maybe @ErikDeSmedt has an opinion here?