Ms 1.3 updates michael - Githubissues

BitcoinDesign / Bitcoin-Core-App

Tracking the design process for the Bitcoin Core App.

https://bitcoincore.app

MIT License

56 stars 11 forks source link

Ms 1.3 updates michael #76

Closed rabbitholiness closed 10 months ago

rabbitholiness commented 1 year ago

Ready for initial review. Final images will probably need tweaking.

GBKS commented 1 year ago

Can you please remove all files and file changes that are unrelated to the content you're editing? That includes:

.DS_Store
Gemfile.lock
LICENSE
README.md
assets/images/import-wallet/.DS_Store
images/bitcoin-core-app-versions.png
images/cross-platform-layouts.png

rabbitholiness commented 11 months ago

@GBKS I think I addressed all of the issues you mentioned.

promag commented 11 months ago

Add .gitignore to avoid committing .DS_Store and other unwanted files, see https://stackoverflow.com/a/107921.

GBKS commented 11 months ago

@promag good idea. I just did that on the gh-pages branch (we had a .gitignore already, I added a .DS_Store entry.

rabbitholiness commented 10 months ago

Thanks for fixing (almost) everything. Could you please remove the Gemfile and the 3 .DS_Store files from the PR? The .DS_Store files are likely hidden, so may need to enable showing hidden files in finder. Otherwise it's ready to go, IMHO.

@GBKS I removed the Gemfile and the .gitignore (as suggested by promag), but I couldn't find any .DS_Store file, even after showing hidden files.

GBKS commented 10 months ago

ACK. Ready to go. I did 3 clean-up commits to:

Restore the gitignore and Gemfile files (we do need them, just the version that is already in the repo, not the changes in this PR).
Delete the _site directory. It contains the files your computer creates when running the site locally. We don't want them in the repo.
Deleted .DS_Store files, which MacOS uses to store information about folders.

Much tidier now.