BitcoinDesign / Bitcoin-Core-App

Tracking the design process for the Bitcoin Core App.
https://bitcoincore.app
MIT License
56 stars 11 forks source link

Improve copy in language selector #95

Closed stackingsaunter closed 9 months ago

stackingsaunter commented 10 months ago

We did a mistake showing country first in language selector, especially showing it when it's not necessary

CleanShot 2024-01-24 at 14 16 02@2x

@GBKS proposed to follow how Apple does this:

CleanShot 2024-01-24 at 14 17 54@2x

So schema looks like this:

Language name in the language itself (Region in the language itself) Language in device set language (Region in device set language)

We show regions only when it's needed, so when we have regional translations for the same language

Another acceptable idea is to just use native language, without device set language, but showing regions where needed:

CleanShot 2024-01-24 at 14 21 55@2x

Yashraj also asked If we can detect machine language and set it automatically at the run of GUI. That would be the best I think, but still I think we should change the selector to one of the designs above^

GBKS commented 10 months ago
Bitcoin Core App language picker 220125

Here's a small update with two layout variations and an added search.

Looking at the basics, the language is always shown in the language itself, and in the currently selected language. The country is only shown to distinguish dialects across countries.

I prefer the horizontal layout as it's more compact and easy to scroll through - this list can be pretty long. For the same reason, I added in a quick search at the top. Additionally, a user should be able to press any keyboard character and the list should scroll to the first language that starts with that character. Obviously works better for some languages than others.

stackingsaunter commented 9 months ago

+1 for horizontal with search, +10 for keyboard live search

GBKS commented 9 months ago

I just updated the design docs page, this language picker is covered in display settings. One thing missing is whether we use the same dropdown on mobile, or go with a full-screen list (probably the latter).

@stackingsaunter can you maybe do a quick review and see if anything is missing, so we can then close out this issue?

GBKS commented 9 months ago

Here are the designs with the drawer version for mobile. I also updated the design docs. Let's call this one done for now, and open up new issues if there are tweaks.

image