BitcoinDesign / Bitcoin-Icons

Icons made for Bitcoin applications, free to use.
https://bitcoinicons.com/
Other
107 stars 21 forks source link

Create a Figma plugin #27

Closed Bosch-0 closed 2 years ago

Bosch-0 commented 3 years ago

Once we have some icons established it would be handy to have a Figma plugin that hosts these icons similar to Material Designs plugin.

AaronDewes commented 2 years ago

grafik

I'm working on it

GBKS commented 2 years ago

@AaronDewes thank you for taking this on. Let me know if you need help (coding or testing).

AaronDewes commented 2 years ago

grafik

Made some progress, the code is available here: https://github.com/AaronDewes/figma-bitcoin-icons

Still need to improve the way the icons are inserted, everything else seems to work.

Bosch-0 commented 2 years ago

This is awesome! Thanks for this Aaron :) Likewise was @GBKS said

GBKS commented 2 years ago

Just tested it, works great. Thank you again.

Looks like you import a module called @runcitadel/bitcoin-icons-svg. Was there a specific reason for creating it? Since you use React, I'm wondering if we can switch to the "official" React module?

Another thought is more about workflow. When I set up icons for a Figma file, I typically create them as components with variants. I wonder if the plugin should/could do this as well? So when you add an icon, it would place the outline and filled icons on the screen as one component with 2 variants. Really not sure how others work, so maybe this is something that could be added in the future if people ask for it.

What is the issue you are seeing with icon insertion and stroke widths?

AaronDewes commented 2 years ago

@runcitadel/bitcoin-icons-svg is PR #87 published on npm.

To insert the icons into Figma, I need the raw svg data as a string, not React components, so it needs a new package.

So when you add an icon, it would place the outline and filled icons on the screen as one component with 2 variants. Really not sure how others work, so maybe this is something that could be added in the future if people ask for it.

I'll try to get that working, thanks for the suggestion.

GBKS commented 2 years ago

Following up on this stale thread, and closing it. The plugin is live and already has 2K downloads. Thank you again for putting it together, Aaron.